Use node v20 for CI #3992
Merged
Use node v20 for CI #3992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @robrichard, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
robrichard
force-pushed
the
robrichard/node20
branch
from
37bc4ed
to
66f3b67
Compare
robrichard
commented
Nov 22, 2023
| @@ -30,10 +30,10 @@ | |||
| }, | |||
| "scripts": { | |||
| "preversion": ". ./resources/checkgit.sh && npm ci --ignore-scripts", | |||
| "version": "ts-node resources/gen-version.ts && npm test && git add src/version.ts", | |||
| "version": "node --loader ts-node/esm resources/gen-version.ts && npm test && git add src/version.ts", | |||
There was a problem hiding this comment.
IvanGoncharov
approved these changes
Nov 22, 2023
|
@IvanGoncharov i think the diff check breaks because it’s loading the prior commit which does not have the fixes in this pr. So I think once this is merged it will start working again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.